Reviewers: Ray Ryan, kjin, Message: Kevin, thanks for looking at this. Are there any other CSS testing use-cases that you can think of that the DebugInfo API should support?
http://gwt-code-reviews.appspot.com/770801/diff/1/5 File user/src/com/google/gwt/resources/client/impl/CssResourceObserver.java (right): http://gwt-code-reviews.appspot.com/770801/diff/1/5#newcode32 user/src/com/google/gwt/resources/client/impl/CssResourceObserver.java:32: private static final CssResourceObserver IMPL = GWT.create(CssResourceObserver.class);
This way there's effectively only one observer instance allowed? I think Observer implies 1-N.
It's a singleton observer the way it's written, but if the developer really cares, a fan-out version could be installed. http://gwt-code-reviews.appspot.com/770801/diff/1/5#newcode68 user/src/com/google/gwt/resources/client/impl/CssResourceObserver.java:68: private native JavaScriptObject ensureMap() /*-{
Do we have to use JSNI?
Yes. The couple of requests that I've seen for the global map have a use-case where a white-box Selenium test would like to be able to determine the obfuscated name for a class selector when inspecting the DOM. http://gwt-code-reviews.appspot.com/770801/diff/1/6 File user/src/com/google/gwt/resources/css/ClassRenamer.java (right): http://gwt-code-reviews.appspot.com/770801/diff/1/6#newcode138 user/src/com/google/gwt/resources/css/ClassRenamer.java:138: sheet.getDebugInfo().addToClassMap(sourceClassName, sourceClassName); It is a builder and should probably be named something like DebugInfoModel. Description: Add debugging information to CssResource. Patch by: bobv Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/770801/show Affected files: A user/src/com/google/gwt/resources/EnableCssResourceDebugging.gwt.xml M user/src/com/google/gwt/resources/Resources.gwt.xml M user/src/com/google/gwt/resources/client/CssResource.java A user/src/com/google/gwt/resources/client/impl/CssResourceObserver.java M user/src/com/google/gwt/resources/css/ClassRenamer.java A user/src/com/google/gwt/resources/css/CssDebugInfo.java A user/src/com/google/gwt/resources/css/CssDebugInfoImpl.java M user/src/com/google/gwt/resources/css/ast/CssStylesheet.java M user/src/com/google/gwt/resources/rg/CssResourceGenerator.java M user/test/com/google/gwt/resources/ResourcesSuite.java M user/test/com/google/gwt/resources/client/CSSResourceTest.java A user/test/com/google/gwt/resources/client/CssResourceDebugInfoTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
