http://gwt-code-reviews.appspot.com/794801/diff/8001/9001
File dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java
(right):

http://gwt-code-reviews.appspot.com/794801/diff/8001/9001#newcode43
dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java:43:
DESC_FLOAT, "0.0");
0f

http://gwt-code-reviews.appspot.com/794801/diff/8001/9002
File user/src/com/google/gwt/uibinder/client/UiChild.java (right):

http://gwt-code-reviews.appspot.com/794801/diff/8001/9002#newcode34
user/src/com/google/gwt/uibinder/client/UiChild.java:34: * lowercase.
"For example, <code>MyWidget.addCustomChild(Widget w)</code> would be
available as
<pre>
<p:MyWidget>
  <p:customchild>
    <g:SomeWidget />
  </p:customchild>
</p:MyWidget>
</pre>

http://gwt-code-reviews.appspot.com/794801/diff/8001/9004
File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
(right):

http://gwt-code-reviews.appspot.com/794801/diff/8001/9004#newcode3
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:3: *
This file still has a lot of whitespace jitter.

http://gwt-code-reviews.appspot.com/794801/diff/8001/9005
File user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java
(right):

http://gwt-code-reviews.appspot.com/794801/diff/8001/9005#newcode270
user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java:270:
if (tag == null || tag.equals("")) {
tag can never be null.

http://gwt-code-reviews.appspot.com/794801/diff/8001/9005#newcode274
user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java:274:
}
If the method name doesn't start with "add" then tag is going to be an
empty string here.

http://gwt-code-reviews.appspot.com/794801/diff/8001/9007
File
user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java
(right):

http://gwt-code-reviews.appspot.com/794801/diff/8001/9007#newcode298
user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java:298:
@UiChild
Add another test method

@UiChild
poorlyNamedMethod(Object child)...

http://gwt-code-reviews.appspot.com/794801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to