LGTM, see TODO comment.


http://gwt-code-reviews.appspot.com/818801/diff/1/2
File
user/src/com/google/gwt/requestfactory/client/impl/RecordJsoImpl.java
(right):

http://gwt-code-reviews.appspot.com/818801/diff/1/2#newcode322
user/src/com/google/gwt/requestfactory/client/impl/RecordJsoImpl.java:322:
// TODO this will not work with null values
Could we delegate to
getRequestFactory().get{Token|Class|Proxy|SomeOtherMethod}(propertyType)?
For example, if these methods, or one that returns RecordSchema could be
configured to return a null if the argument is not a Record class, then
we could dispense with instance of (which inhibits the ability to use
JSOs directly in the future)

http://gwt-code-reviews.appspot.com/818801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to