This method used to be called by the compiler because of some "interesting" SWT/AWT interaction on mac. It might be worth looking to see where it is called these days:
http://www.google.com/codesearch/p?hl=en#A1edwVHBClQ/dev/core/src/com/google/gwt/dev/BootStrapPlatform.java&%20package:http://google-web-toolkit%5C.googlecode%5C.com&sa=N&cd=1&ct=rc&l=38 On 2010/08/31 21:47:43, zundel wrote:
I went over to my Mac and ran a compile under GPE and it worked fine
(I seemed
to get a measurable speedup too.)
I consolidated the thread logic and removed the static member, but
left the
Thread subclass defined by itself just not to clutter the precompile()
method.
http://gwt-code-reviews.appspot.com/822801/diff/1/2 File dev/core/src/com/google/gwt/dev/Precompile.java (right):
http://gwt-code-reviews.appspot.com/822801/diff/1/2#newcode390 dev/core/src/com/google/gwt/dev/Precompile.java:390:
createGraphicsEvent.end();
On 2010/08/31 21:11:48, scottb wrote: > This looks fine, but my only comment is whether or not this can be
boiled down
> to something more general that would get the same effect? e.g. > GraphicsEnvironment.getLocalGraphicsEnvironment().
GraphicsEnvironment.getLocalGraphicsEnvironment() works. Updated.
http://gwt-code-reviews.appspot.com/822801/diff/1/2#newcode401 dev/core/src/com/google/gwt/dev/Precompile.java:401: private static
Thread
graphicsInitThread = new GraphicsInitThread(); On 2010/08/31 21:13:05, scottb wrote: > Oh yeah.. any particular reason to make this a field? Should just
be a local
> var. I'd almost argue for making the Thread a local class, too.
Originally I had a graphicsInitThread.join() in a particular place. I
decided I
didn't need that, so I removed it.
http://gwt-code-reviews.appspot.com/822801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
