Reviewers: cromwellian, amitmanjhi,
Description:
Provides support for fix of
https://jira.springsource.org/browse/ROO-1287 (ValueListBox showing
redundant entries) by allowing ValueListBox to use a key provider.
In the course of working on this, I found spots where we were swallowing
exceptions on the server. Now we don't.
I also ran into a bug where ProxyJsoImpl.getRequestFactory() would
return null,
but only for proxies created via certain code paths. Now it should be
impossible
to create a ProxyJsoImpl that doesn't have both its factory and its
schema, or
at least pretty difficult.
Review by: cromwell...@google.com
Please review this at http://gwt-code-reviews.appspot.com/841803/show
Affected files:
M user/src/com/google/gwt/app/place/AbstractProxyListActivity.java
A user/src/com/google/gwt/app/place/EntityProxyKeyProvider.java
M
user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonListRequest.java
M
user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonObjectRequest.java
M user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java
M
user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java
A user/src/com/google/gwt/requestfactory/client/impl/JsonResults.java
M user/src/com/google/gwt/requestfactory/client/impl/ProxyImpl.java
M user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java
M user/src/com/google/gwt/requestfactory/client/impl/ProxySchema.java
M user/src/com/google/gwt/requestfactory/client/impl/ProxyToTypeMap.java
M
user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java
M
user/src/com/google/gwt/requestfactory/client/impl/ValueStoreJsonImpl.java
M
user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java
M user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
M user/src/com/google/gwt/user/client/ui/ValueBoxBase.java
M user/src/com/google/gwt/user/client/ui/ValueListBox.java
A user/src/com/google/gwt/view/client/SimpleKeyProvider.java
M user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java
M
user/test/com/google/gwt/requestfactory/client/SimpleRequestFactoryInstance.java
M
user/test/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImplTest.java
M
user/test/com/google/gwt/requestfactory/client/impl/EntityProxyIdTest.java
M
user/test/com/google/gwt/requestfactory/client/impl/ProxyJsoImplTest.java
M
user/test/com/google/gwt/requestfactory/server/JsonRequestProcessorTest.java
M user/test/com/google/gwt/user/client/ui/ValueListBoxTest.java
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
