http://gwt-code-reviews.appspot.com/849801/diff/1/2 File user/test/com/google/gwt/emultest/java/sql/SqlDateTest.java (right):
http://gwt-code-reviews.appspot.com/849801/diff/1/2#newcode39 user/test/com/google/gwt/emultest/java/sql/SqlDateTest.java:39: long millis = 1000000; Perhaps test with 100000 and also a much larger value, since subtracting a day from 100000 will result in a negative (pre Jan 1, 1970) value. It would be worth testing cases where things stay positive. For reference, the current Java timestamp in milliseconds is around 1283895273475. http://gwt-code-reviews.appspot.com/849801/diff/1/3 File user/test/com/google/gwt/emultest/java/sql/SqlTimeTest.java (right): http://gwt-code-reviews.appspot.com/849801/diff/1/3#newcode127 user/test/com/google/gwt/emultest/java/sql/SqlTimeTest.java:127: long millis = 1000000; See comments for SqlTimestampTest. http://gwt-code-reviews.appspot.com/849801/diff/1/4 File user/test/com/google/gwt/emultest/java/sql/SqlTimestampTest.java (right): http://gwt-code-reviews.appspot.com/849801/diff/1/4#newcode44 user/test/com/google/gwt/emultest/java/sql/SqlTimestampTest.java:44: long now = 1000000; I would suggest refactoring the test so both cases (now % 1000) == 0 and (now % 1000 != 0) are tested. http://gwt-code-reviews.appspot.com/849801/diff/1/4#newcode73 user/test/com/google/gwt/emultest/java/sql/SqlTimestampTest.java:73: long now = 1000000; Ditto http://gwt-code-reviews.appspot.com/849801/diff/1/4#newcode88 user/test/com/google/gwt/emultest/java/sql/SqlTimestampTest.java:88: long now = 1000000; Ditto http://gwt-code-reviews.appspot.com/849801/diff/1/4#newcode110 user/test/com/google/gwt/emultest/java/sql/SqlTimestampTest.java:110: long now = 1000000; Ditto http://gwt-code-reviews.appspot.com/849801/diff/1/4#newcode137 user/test/com/google/gwt/emultest/java/sql/SqlTimestampTest.java:137: long now = (1000000 / 1000) * 1000 + 5; Might as well just say 'long now = 100005;' since everything is a constant. http://gwt-code-reviews.appspot.com/849801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
