On Friday, September 10, 2010, <p...@google.com> wrote: > One of the reasons to delegate to setHTML() is to support external > implementations that have overridden setHTML(). Your suggestion makes a > lot of sense, but to support the external users, I think we should stick > with the setHTML() version. SGTM.
> > http://gwt-code-reviews.appspot.com/847801/diff/8002/13034#newcode48 > user/test/com/google/gwt/user/client/ui/AnchorTest.java:48: static final > String html = "<b>hello</b><i>world</i>"; > On 2010/09/10 02:19:38, xtof wrote: > > should this be private, and HTML? > > > > (here and elsewhere?) > > GWT's style guide is trying to push for treating acronyms as words > (Good: XmlHttpRequest, Bad: XMLHTTPRequest), which is why I used > lowercase. I have gone through and added private though. I actually wasn't thinking upper case because it happens to be an acronym, but rather because it's a constant (static final). I'm not that familiar with the GWT style guide though and if it requires those to be upper case... --xtof -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
