LGTM

Just take a look at the assertsOn thing in the tests.


http://gwt-code-reviews.appspot.com/841804/diff/58001/45043
File user/test/com/google/gwt/event/shared/HandlerManagerTest.java
(right):

http://gwt-code-reviews.appspot.com/841804/diff/58001/45043#newcode197
user/test/com/google/gwt/event/shared/HandlerManagerTest.java:197:
assert assertsOn = true;
Intentional?  It looks like an accidental boolean assignment.

http://gwt-code-reviews.appspot.com/841804/diff/58001/45044
File user/test/com/google/gwt/event/shared/SimpleEventBusTest.java
(right):

http://gwt-code-reviews.appspot.com/841804/diff/58001/45044#newcode341
user/test/com/google/gwt/event/shared/SimpleEventBusTest.java:341:
assert assertsOn = true;
Accidental boolean assignment?

http://gwt-code-reviews.appspot.com/841804/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to