LGTM.

Are there any GWT widgets that override onLoad / onUnload without
calling super?

Would this be better as an event type instead of a delegate?


http://gwt-code-reviews.appspot.com/866801/diff/1/2
File user/src/com/google/gwt/user/client/ui/Widget.java (right):

http://gwt-code-reviews.appspot.com/866801/diff/1/2#newcode43
user/src/com/google/gwt/user/client/ui/Widget.java:43: * the default
implementation of {...@link Widget#onLoad()}.
Awkward sentence construction in these methods' JavaDoc.

Called by the default implementation of {...@link Widget#onLoad} when the
Widget is attached to the document.

http://gwt-code-reviews.appspot.com/866801/diff/1/2#newcode387
user/src/com/google/gwt/user/client/ui/Widget.java:387: * browser's
document.
Indicate the default behavior in onLoad() and onUnload()'s
documentation.

http://gwt-code-reviews.appspot.com/866801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to