http://gwt-code-reviews.appspot.com/888801/diff/1/2
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/FavoritesWidget.java
(right):

http://gwt-code-reviews.appspot.com/888801/diff/1/2#newcode67
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/FavoritesWidget.java:67:
public NameLabel create(int index) {
This should have occurred to me the other day.

It's a shame that we can't use cells here instead of generating a widget
per editor. Given our paucity of cells and abundance of widgets, I don't
that relying only on a cell based approach would fly this week. But do
you think we will be able to retrofit a CellEditorSource, something that
shares out a cell singleton rather than a widget per list item?

http://gwt-code-reviews.appspot.com/888801/diff/1/2#newcode121
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/FavoritesWidget.java:121:
driver.edit(new ArrayList<PersonProxy>(), null);
How about making driver.display(new ArrayList<PersonProxy>()) which in
turn makes this null request call? Would display make sense as a method
on EditorDriver itself?

http://gwt-code-reviews.appspot.com/888801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to