LGTM with nit.

http://gwt-code-reviews.appspot.com/887801/diff/4002/5004
File
dev/core/src/com/google/gwt/dev/resource/impl/ResourceOracleImpl.java
(right):

http://gwt-code-reviews.appspot.com/887801/diff/4002/5004#newcode183
dev/core/src/com/google/gwt/dev/resource/impl/ResourceOracleImpl.java:183:
"You must pass at least one oracle to refresh.");
There's a better way. :)

public static void refresh(TreeLogger logger, ResourceOracleImpl first,
ResourceOracleImpl... rest)

Then you can verify statically that there's at least one, and the
EmbeddedTomcat caller would have shown up as a compile-time error.

http://gwt-code-reviews.appspot.com/887801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to