Thanks, Rodrigo. Fixing the nits, but as I mentioned offline, I'm going to hold off on the remnant here until I fix the fundamental "oops, creation places don't work now that we've moved entirely to EntityProxyId".
http://gwt-code-reviews.appspot.com/896801/diff/3001/2008 File user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java (right): http://gwt-code-reviews.appspot.com/896801/diff/3001/2008#newcode46 user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:46: * @param <P> the type of Proxy being edited On 2010/09/19 17:48:34, rchandia wrote:
Too many @params.
Done. http://gwt-code-reviews.appspot.com/896801/diff/3001/2008#newcode51 user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:51: private RequestObject<? extends Object> requestObject; I would have sworn that was not true, but the compiler is clearly on your side. On 2010/09/19 17:48:34, rchandia wrote:
Same as RequestObject<?> requestObject;
http://gwt-code-reviews.appspot.com/896801/diff/3001/2010 File user/src/com/google/gwt/app/place/AbstractProxyListView.java (right): http://gwt-code-reviews.appspot.com/896801/diff/3001/2010#newcode68 user/src/com/google/gwt/app/place/AbstractProxyListView.java:68: protected void init(Widget root, CellTable<P> table, Button newButton, In this case I don't, because it's meant to replace Composite#init. So much for consistency. On 2010/09/19 17:48:34, rchandia wrote:
Should this rather be initialize()?
http://gwt-code-reviews.appspot.com/896801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
