[gwt-contrib] Re: Replaces the public and obnoxious String EntityProxy#getId() with the (issue902801)

[Amit Manjhi]

LGTM, with a TODO (amitmanjhi) to change SimpleFoo id to String and checking
if everything works.

On Mon, Sep 20, 2010 at 9:15 PM, Amit Manjhi <amitman...@google.com> wrote:

> checkstyle fails probably because
>
> <file
> name="trunk/user/src/com/google/gwt/requestfactory/client/impl/DeltaValueStoreJsonImpl.java">
> <error line="72" column="5" severity="error" message="getEncodedId is not
> alphabetical." source="com.google.gwt.checkstyle.OrderCheck"/>
> </file>
>
> <file
> name="trunk/user/src/com/google/gwt/requestfactory/shared/EntityProxyId.java">
> <error line="25" severity="error" message="Type Javadoc comment is missing
> an @param &lt;P&gt; tag."
> source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTypeCheck"/>
> </file>
>
> More comments coming...
>
>
> On Mon, Sep 20, 2010 at 8:49 PM, <rj...@google.com> wrote:
>
>> http://gwt-code-reviews.appspot.com/902801/show
>>
>
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors