Looks like there's a regression in IconCellDecorator (re. valign)


http://gwt-code-reviews.appspot.com/912801/diff/1/2
File user/src/com/google/gwt/cell/client/IconCellDecorator.java (right):

http://gwt-code-reviews.appspot.com/912801/diff/1/2#newcode53
user/src/com/google/gwt/cell/client/IconCellDecorator.java:53:
@Template("<div style=\"position:absolute;{0}:0px;top:0px;height:100%;"
Just wondering: if height:100% works, wouldn't absolute positioning work
too, instead of a table wrapper? (something like "top:50%;
margin-top:-{height}px")

http://gwt-code-reviews.appspot.com/912801/diff/1/2#newcode99
user/src/com/google/gwt/cell/client/IconCellDecorator.java:99:
this.imageWidth = icon.getWidth() + 6;
I know it's not the purpose of this patch but... should this "6" be
"spacing"?

http://gwt-code-reviews.appspot.com/912801/diff/1/2#newcode175
user/src/com/google/gwt/cell/client/IconCellDecorator.java:175: return
template.imageWrapper(direction, res.getWidth(), image);
looks like valign is no longer used (!?)

http://gwt-code-reviews.appspot.com/912801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to