LGTM On Mon, Oct 4, 2010 at 3:11 PM, <rchan...@google.com> wrote:
> Reviewers: amitmanjhi, > > Description: > Fixes to use Java 1.5 compatible JARs > > Fixed DynaTableRf eclipse .classpath to use json-1.5.jar > Fixed build scripts and eclipse classpaths to use java 1.5 compatible > StreamHtmlParser JAR > > Review by: amitman...@google.com > > Please review this at http://gwt-code-reviews.appspot.com/939802/show > > Affected files: > M dev/build.xml > M eclipse/samples/DynaTableRf/.classpath > M eclipse/user/.classpath > > > Index: dev/build.xml > =================================================================== > --- dev/build.xml (revision 8929) > +++ dev/build.xml (working copy) > @@ -100,7 +100,7 @@ > <include name="htmlunit/htmlunit-r5940/htmlunit-r5940.jar" /> > <include > name="htmlunit/htmlunit-r5940/htmlunit-core-js-r5940.jar" /> > <include name="nekohtml/nekohtml-1.9.13.jar" /> > - <include > name="streamhtmlparser/streamhtmlparser-jsilver-r10/streamhtmlparser-jsilver-r10-rebased.jar" > /> > + <include > name="streamhtmlparser/streamhtmlparser-jsilver-r10/streamhtmlparser-jsilver-r10-1.5-rebased.jar" > /> > <include name="xalan/xalan-2.7.1.jar" /> > <include name="xerces/xerces-2_9_1/serializer.jar" /> > <include name="xerces/xerces-2_9_1/xercesImpl-NoMetaInf.jar" /> > @@ -124,7 +124,7 @@ > <zipfileset src="${gwt.tools.lib}/jetty/jetty-6.1.11.jar" /> > <zipfileset src="${gwt.tools.lib}/icu4j/icu4j-4_4_1.jar" /> > <zipfileset > src="${gwt.tools.lib}/protobuf/protobuf-2.2.0/protobuf-java-rebased-2.2.0.jar" > /> > - <zipfileset > src="${gwt.tools.lib}/streamhtmlparser/streamhtmlparser-jsilver-r10/streamhtmlparser-jsilver-r10-rebased.jar" > /> > + <zipfileset > src="${gwt.tools.lib}/streamhtmlparser/streamhtmlparser-jsilver-r10/streamhtmlparser-jsilver-r10-1.5-rebased.jar" > /> > <zipfileset src="${gwt.tools.lib}/tomcat/ant-launcher-1.6.5.jar" > /> > <zipfileset src="${gwt.tools.lib}/tomcat/catalina-1.0.jar" /> > <zipfileset > src="${gwt.tools.lib}/tomcat/catalina-optional-1.0.jar" /> > Index: eclipse/samples/DynaTableRf/.classpath > =================================================================== > --- eclipse/samples/DynaTableRf/.classpath (revision 8929) > +++ eclipse/samples/DynaTableRf/.classpath (working copy) > @@ -6,6 +6,6 @@ > <classpathentry combineaccessrules="false" kind="src" > path="/gwt-user"/> > <classpathentry kind="var" > path="GWT_TOOLS/lib/javax/validation/validation-api-1.0.0.GA.jar" > sourcepath="/GWT_TOOLS/lib/javax/validation/validation-api-1.0.0.GA-sources.jar"/> > <classpathentry kind="var" > path="GWT_TOOLS/lib/javax/validation/validation-api-1.0.0.GA-sources.jar"/> > - <classpathentry kind="var" > path="GWT_TOOLS/redist/json/r2_20080312/json.jar"/> > + <classpathentry kind="var" > path="GWT_TOOLS/redist/json/r2_20080312/json-1.5.jar"/> > <classpathentry kind="output" path="war/WEB-INF/classes"/> > </classpath> > Index: eclipse/user/.classpath > =================================================================== > --- eclipse/user/.classpath (revision 8929) > +++ eclipse/user/.classpath (working copy) > @@ -40,6 +40,6 @@ > <classpathentry exported="true" kind="var" > path="GWT_TOOLS/lib/javax/validation/validation-api-1.0.0.GA-sources.jar"/> > <classpathentry kind="var" > path="GWT_TOOLS/lib/jetty/jetty-6.1.11.jar" > sourcepath="/GWT_TOOLS/lib/jetty/jetty-6.1.11-src.zip"/> > <classpathentry kind="var" > path="GWT_TOOLS/lib/guava/guava-r06/guava-r06-rebased.jar"/> > - <classpathentry kind="var" > path="GWT_TOOLS/lib/streamhtmlparser/streamhtmlparser-jsilver-r10/streamhtmlparser-jsilver-r10-rebased.jar"/> > + <classpathentry kind="var" > path="GWT_TOOLS/lib/streamhtmlparser/streamhtmlparser-jsilver-r10/streamhtmlparser-jsilver-r10-1.5-rebased.jar"/> > <classpathentry kind="output" path="bin"/> > </classpath> > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
