Point taken on the view contention front. I think Thomas is right that
setting and clearing the view delegate should happen in start() and stop(),
not in the constructor. Thanks, Thomas.

On Mon, Sep 27, 2010 at 12:46 PM, <t.bro...@gmail.com> wrote:

>
> http://gwt-code-reviews.appspot.com/925801/diff/1/2
> File user/src/com/google/gwt/app/place/AbstractProxyListActivity.java
> (right):
>
> http://gwt-code-reviews.appspot.com/925801/diff/1/2#newcode256
> user/src/com/google/gwt/app/place/AbstractProxyListActivity.java:256: if
> (view == null) {
> On 2010/09/27 18:55:21, rjrjr wrote:
>
>> The activities have never been intended to be re-used.
>>
>
> Yes, but there's another issue with initializing in the constructor
> (while sharing a singleton view between activity instances); see my
> reply on the issue "front page" (don't know how you call it).
> I don't have a dev env right now; will try to produce a test case
> tomorrow demonstrating the issue (unless I'm wrong in my reading of the
> code).
>
>
>  Sounds like the javadoc should say so.
>>
>
> +1
>
>
> http://gwt-code-reviews.appspot.com/925801/show
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to