Per our offline discussion, you should do the version check before bothering with any diff checks — if the client is stale, we know it needs to update the entity regardless of what happens when the method fires.
It's tempting to rip out the diff mechanism entirely, but this is not the the time. On Tue, Oct 5, 2010 at 10:11 AM, <amitman...@google.com> wrote: > Reviewers: rjrjr, robertvawter, > > Description: > Send an update notification to a stale client by comparing the incoming > version > number, with the version number on the server. This code path will only > be > taken if the ORM system has not flagged any errors. > > Hacked the test harness so that the version number is only incremented > on a > real change. Will fix the test harness shortly in a follow-up patch. > > Patch by: amitmanjhi > Review by: rjrjr, robertvawter > > > Please review this at http://gwt-code-reviews.appspot.com/959801/show > > Affected files: > M user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java > M > user/test/com/google/gwt/requestfactory/server/JsonRequestProcessorTest.java > M user/test/com/google/gwt/requestfactory/server/SimpleFoo.java > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
