[gwt-contrib] Relaxing the data parameter of HasData#setRowData() from a List to a List. (issue994801)

[jlabanca]

Reviewers: rice,

Description:
Relaxing the data parameter of HasData#setRowData() from a List<T> to a
List<? extends T>.

Please review this at http://gwt-code-reviews.appspot.com/994801/show

Affected files:
  M user/src/com/google/gwt/user/cellview/client/AbstractHasData.java
  M user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java
  M user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java
  M user/src/com/google/gwt/view/client/HasData.java
  M user/test/com/google/gwt/view/client/MockHasData.java


Index: user/src/com/google/gwt/user/cellview/client/AbstractHasData.java
===================================================================
--- user/src/com/google/gwt/user/cellview/client/AbstractHasData.java	 
(revision 9038)
+++ user/src/com/google/gwt/user/cellview/client/AbstractHasData.java	 
(working copy)
@@ -535,7 +535,7 @@
     presenter.setRowCount(size, isExact);
   }

-  public void setRowData(int start, List<T> values) {
+  public void setRowData(int start, List<? extends T> values) {
     presenter.setRowData(start, values);
   }

Index: user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java
===================================================================
--- user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java	 
(revision 9038)
+++ user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java	 
(working copy)
@@ -492,7 +492,7 @@
       presenter.setRowCount(size, isExact);
     }

-    public void setRowData(int start, List<C> values) {
+    public void setRowData(int start, List<? extends C> values) {
       presenter.setRowData(start, values);
     }

Index: user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java
===================================================================
--- user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java	 
(revision 9038)
+++ user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java	 
(working copy)
@@ -651,7 +651,7 @@
     RowCountChangeEvent.fire(display, count, rowCountIsExact);
   }

-  public void setRowData(int start, List<T> values) {
+  public void setRowData(int start, List<? extends T> values) {
     int valuesLength = values.size();
     int valuesEnd = start + valuesLength;

Index: user/src/com/google/gwt/view/client/HasData.java
===================================================================
--- user/src/com/google/gwt/view/client/HasData.java    (revision 9038)
+++ user/src/com/google/gwt/view/client/HasData.java    (working copy)
@@ -39,7 +39,7 @@
    * @param start the start index of the data
    * @param values the values within the range
    */
-  void setRowData(int start, List<T> values);
+  void setRowData(int start, List<? extends T> values);

   /**
    * Set the {...@link SelectionModel} used by this {...@link HasData}.
Index: user/test/com/google/gwt/view/client/MockHasData.java
===================================================================
--- user/test/com/google/gwt/view/client/MockHasData.java       (revision 9038)
+++ user/test/com/google/gwt/view/client/MockHasData.java       (working copy)
@@ -81,7 +81,7 @@

   private final HandlerManager handlerManager = new HandlerManager(this);
   private Range lastRange;
-  private List<T> lastRowData;
+  private List<? extends T> lastRowData;

   private int pageStart;
   private int pageSize = DEFAULT_PAGE_SIZE;
@@ -117,7 +117,7 @@
    *
    * @return the last data set
    */
-  public List<T> getLastRowData() {
+  public List<? extends T> getLastRowData() {
     return lastRowData;
   }

@@ -146,7 +146,7 @@
     return rowCountExact;
   }

-  public void setRowData(int start, List<T> values) {
+  public void setRowData(int start, List<? extends T> values) {
     lastRange = new Range(start, values.size());
     lastRowData = values;
   }


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors