Revision: 9053
Author: jlaba...@google.com
Date: Wed Oct 13 10:24:11 2010
Log: Relaxing the data parameter of HasData#setRowData() from a List<T> to
a List<? extends T>.
Review at http://gwt-code-reviews.appspot.com/994801
http://code.google.com/p/google-web-toolkit/source/detail?r=9053
Modified:
/trunk/user/src/com/google/gwt/user/cellview/client/AbstractHasData.java
/trunk/user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java
/trunk/user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java
/trunk/user/src/com/google/gwt/view/client/HasData.java
/trunk/user/test/com/google/gwt/view/client/MockHasData.java
=======================================
---
/trunk/user/src/com/google/gwt/user/cellview/client/AbstractHasData.java
Tue Oct 12 07:55:56 2010
+++
/trunk/user/src/com/google/gwt/user/cellview/client/AbstractHasData.java
Wed Oct 13 10:24:11 2010
@@ -535,7 +535,7 @@
presenter.setRowCount(size, isExact);
}
- public void setRowData(int start, List<T> values) {
+ public void setRowData(int start, List<? extends T> values) {
presenter.setRowData(start, values);
}
=======================================
---
/trunk/user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java
Wed Oct 13 12:59:56 2010
+++
/trunk/user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java
Wed Oct 13 10:24:11 2010
@@ -492,7 +492,7 @@
presenter.setRowCount(size, isExact);
}
- public void setRowData(int start, List<C> values) {
+ public void setRowData(int start, List<? extends C> values) {
presenter.setRowData(start, values);
}
=======================================
---
/trunk/user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java
Wed Oct 6 11:53:24 2010
+++
/trunk/user/src/com/google/gwt/user/cellview/client/HasDataPresenter.java
Wed Oct 13 10:24:11 2010
@@ -651,7 +651,7 @@
RowCountChangeEvent.fire(display, count, rowCountIsExact);
}
- public void setRowData(int start, List<T> values) {
+ public void setRowData(int start, List<? extends T> values) {
int valuesLength = values.size();
int valuesEnd = start + valuesLength;
=======================================
--- /trunk/user/src/com/google/gwt/view/client/HasData.java Tue Oct 12
07:55:56 2010
+++ /trunk/user/src/com/google/gwt/view/client/HasData.java Wed Oct 13
10:24:11 2010
@@ -39,7 +39,7 @@
* @param start the start index of the data
* @param values the values within the range
*/
- void setRowData(int start, List<T> values);
+ void setRowData(int start, List<? extends T> values);
/**
* Set the {...@link SelectionModel} used by this {...@link HasData}.
=======================================
--- /trunk/user/test/com/google/gwt/view/client/MockHasData.java Tue Aug 17
10:14:36 2010
+++ /trunk/user/test/com/google/gwt/view/client/MockHasData.java Wed Oct 13
10:24:11 2010
@@ -81,7 +81,7 @@
private final HandlerManager handlerManager = new HandlerManager(this);
private Range lastRange;
- private List<T> lastRowData;
+ private List<? extends T> lastRowData;
private int pageStart;
private int pageSize = DEFAULT_PAGE_SIZE;
@@ -117,7 +117,7 @@
*
* @return the last data set
*/
- public List<T> getLastRowData() {
+ public List<? extends T> getLastRowData() {
return lastRowData;
}
@@ -146,7 +146,7 @@
return rowCountExact;
}
- public void setRowData(int start, List<T> values) {
+ public void setRowData(int start, List<? extends T> values) {
lastRange = new Range(start, values.size());
lastRowData = values;
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors