http://gwt-code-reviews.appspot.com/975801/diff/1/2
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DynaTableRf.java
(right):

http://gwt-code-reviews.appspot.com/975801/diff/1/2#newcode67
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DynaTableRf.java:67:
mole.show("Error: " + e.getMessage());
On 2010/10/13 05:33:42, rjrjr wrote:
How does it go away again?

Really should be using the logging handlers for this anyway.

http://gwt-code-reviews.appspot.com/975801/diff/1/12
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/ZipPlusFourBox.java
(right):

http://gwt-code-reviews.appspot.com/975801/diff/1/12#newcode28
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/ZipPlusFourBox.java:28:
* A simple implementation of a US zip code input field.
Changed the Zip type to string.

http://gwt-code-reviews.appspot.com/975801/diff/1/16
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/server/PersonSource.java
(right):

http://gwt-code-reviews.appspot.com/975801/diff/1/16#newcode63
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/server/PersonSource.java:63:
while (toReturn.size() < maxCount && it.hasNext()) {
On 2010/10/13 05:33:42, rjrjr wrote:
Are you sure this is any more efficient than subList? Seems unlikely.

It's necessary for filtering responses. I have added a faster path for
all-on or all-off filters.

http://gwt-code-reviews.appspot.com/975801/diff/1/20
File user/src/com/google/gwt/editor/client/IsEditor.java (right):

http://gwt-code-reviews.appspot.com/975801/diff/1/20#newcode45
user/src/com/google/gwt/editor/client/IsEditor.java:45: * IsEditor
instance.
On 2010/10/13 05:33:42, rjrjr wrote:
What does that mean, "co-editor"?

Multiple editors can be attached to the same domain object.  The
ValueBoxEditorDecorator uses this to intercept error messages.

http://gwt-code-reviews.appspot.com/975801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to