Could any of the three of you take this review? John or Dan might want to look at http://code.google.com/p/google-web-toolkit/source/detail?r=9091 for context.
On Sat, Oct 16, 2010 at 1:39 AM, <rj...@google.com> wrote: > Reviewers: bobv, jlabanca, rice, > > Description: > Brings history support to samples/expenses. Doesn't handle paging -- > sorry Chris, out of time -- and doesn't separate widgets from their > presenters. But still not a bad clean up, and hey! Book marks! > > > Please review this at http://gwt-code-reviews.appspot.com/1020801/show > > Affected files: > A > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/DenialPopup.java > D > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseDetails.java > D > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseDetails.ui.xml > D > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseList.java > D > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseList.ui.xml > A > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportDetails.java > A > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportDetails.ui.xml > A > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportList.java > A > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportList.ui.xml > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseTree.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/Expenses.java > A > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesActivityMapper.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesApp.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesShell.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpensesShell.ui.xml > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/SlidingPanel.java > A > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ioc/ExpensesFactory.java > D > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ioc/Factory.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ExpensesPlaceHistoryMapper.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ReportListPlace.java > M > samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/place/ReportPlace.java > M user/src/com/google/gwt/place/shared/PlaceHistoryHandler.java > > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
