http://gwt-code-reviews.appspot.com/1025801/diff/1/7 File tools/cldr-import/src/com/google/gwt/tools/cldr/LocalizedNamesProcessor.java (right):
http://gwt-code-reviews.appspot.com/1025801/diff/1/7#newcode30 tools/cldr-import/src/com/google/gwt/tools/cldr/LocalizedNamesProcessor.java:30: import java.util.Collections; These aren't alphabetical. http://gwt-code-reviews.appspot.com/1025801/diff/1/7#newcode96 tools/cldr-import/src/com/google/gwt/tools/cldr/LocalizedNamesProcessor.java:96: if (!"ZZ".equals(regionCode) && regionCode.length() == 2) { In the case of a 3-letter regionCode: can they always be ignored? (because they are aliases?) http://gwt-code-reviews.appspot.com/1025801/diff/1/7#newcode129 tools/cldr-import/src/com/google/gwt/tools/cldr/LocalizedNamesProcessor.java:129: if (++count > 10 || region.getLiteratePopulation() < 3000000) { Why stop at 3M? http://gwt-code-reviews.appspot.com/1025801/diff/1/7#newcode185 tools/cldr-import/src/com/google/gwt/tools/cldr/LocalizedNamesProcessor.java:185: generateDefaultLocale(namesMap, regionCodesWithNames, sortOrder, likelyOrder); length > 80 chars. http://gwt-code-reviews.appspot.com/1025801/diff/1/7#newcode308 tools/cldr-import/src/com/google/gwt/tools/cldr/LocalizedNamesProcessor.java:308: pw.println(" protected native JavaScriptObject loadNameMapNative() /*-{"); length > 80chars. http://gwt-code-reviews.appspot.com/1025801/diff/1/7#newcode361 tools/cldr-import/src/com/google/gwt/tools/cldr/LocalizedNamesProcessor.java:361: private void writeStringListMethod(PrintWriter pw, String methodName, String[] values) { length > 80chars. http://gwt-code-reviews.appspot.com/1025801/diff/1/7#newcode367 tools/cldr-import/src/com/google/gwt/tools/cldr/LocalizedNamesProcessor.java:367: pw.println(" \"" + Processor.quote(code) + "\","); This will print an extra comma http://gwt-code-reviews.appspot.com/1025801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
