http://gwt-code-reviews.appspot.com/1085801/diff/3001/4001 File samples/build.xml (right):
http://gwt-code-reviews.appspot.com/1085801/diff/3001/4001#newcode46 samples/build.xml:46: <gwt.ant dir="validation" /> On 2010/11/09 22:11:55, rchandia wrote:
This should be <gwt.ant dir="validationtck" /> if we want the
ValidationTck
sample to appear in the generated gwt-x.y.z.zip distribution.
But with that the ant build fails because there is no war folder under samples/validationtck.
Done. http://gwt-code-reviews.appspot.com/1085801/diff/3001/4002 File samples/common.ant.xml (right): http://gwt-code-reviews.appspot.com/1085801/diff/3001/4002#newcode159 samples/common.ant.xml:159: <exclude name="org/**/super/org/**/*.java"/> On 2010/11/09 22:11:55, rchandia wrote:
Do we really need to disable Checkstyle from all samples? Checkstyle
is supposed
to be able to deal with super source.
All of the Super source I override from org.* is source code that I am modifying, not rewriting so I try to minimize the diffs. If you prefer I could list the much the packages individually as needed. http://gwt-code-reviews.appspot.com/1085801/diff/3001/4021 File samples/validationtck/src/org/testng/super/org/testng/ITestNGMethod.java (right): http://gwt-code-reviews.appspot.com/1085801/diff/3001/4021#newcode2 samples/validationtck/src/org/testng/super/org/testng/ITestNGMethod.java:2: // removed reflect.Method On 2010/11/09 22:11:55, rchandia wrote:
Move these comments to the class documentation.
Done. http://gwt-code-reviews.appspot.com/1085801/diff/3001/4021#newcode7 samples/validationtck/src/org/testng/super/org/testng/ITestNGMethod.java:7: //import java.lang.reflect.Method; On 2010/11/09 22:11:55, rchandia wrote:
Delete
Done. http://gwt-code-reviews.appspot.com/1085801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
