http://gwt-code-reviews.appspot.com/1109801/diff/1/2 File user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java (right):
http://gwt-code-reviews.appspot.com/1109801/diff/1/2#newcode24 user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java:24: * Parses widgets that inherit from {...@link com.google.gwt.user.client.ui.HasHorizontalAlignment}. wrong class linked http://gwt-code-reviews.appspot.com/1109801/diff/1/3 File user/src/com/google/gwt/uibinder/elementparsers/HasHorizontalAlignmentParser.java (right): http://gwt-code-reviews.appspot.com/1109801/diff/1/3#newcode32 user/src/com/google/gwt/uibinder/elementparsers/HasHorizontalAlignmentParser.java:32: writer.getDesignTime().handleUIObject(writer, elem, fieldName); why? http://gwt-code-reviews.appspot.com/1109801/diff/1/4 File user/src/com/google/gwt/uibinder/elementparsers/HasVerticalAlignmentParser.java (right): http://gwt-code-reviews.appspot.com/1109801/diff/1/4#newcode32 user/src/com/google/gwt/uibinder/elementparsers/HasVerticalAlignmentParser.java:32: writer.getDesignTime().handleUIObject(writer, elem, fieldName); ditto http://gwt-code-reviews.appspot.com/1109801/diff/1/5 File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (right): http://gwt-code-reviews.appspot.com/1109801/diff/1/5#newcode1000 user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:1000: addWidgetParser("HasAlignment"); It won't fire for widgets that implement only HasHorizontalAlignment or HasVerticalAlignment, which is not a small set. Is that okay? If so, I'd inline the other two parsers into HasAlignment, or someone will wonder why the more specific ones don't always fire. Should also document in HasAlignmentParser why it's necessary (link to the issue), since it's redundant with BeanParser. http://gwt-code-reviews.appspot.com/1109801/diff/1/6 File user/test/com/google/gwt/uibinder/elementparsers/HasAlignmentParserTest.java (right): http://gwt-code-reviews.appspot.com/1109801/diff/1/6#newcode2 user/test/com/google/gwt/uibinder/elementparsers/HasAlignmentParserTest.java:2: * Copyright 2009 Google Inc. 2010 http://gwt-code-reviews.appspot.com/1109801/diff/1/6#newcode38 user/test/com/google/gwt/uibinder/elementparsers/HasAlignmentParserTest.java:38: } Should test success case as well. And should test that the two attributes are optional. http://gwt-code-reviews.appspot.com/1109801/diff/1/7 File user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java (right): http://gwt-code-reviews.appspot.com/1109801/diff/1/7#newcode579 user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java:579: "class=\"gwt-StackPanelItem"); This fails w/o the new parser? http://gwt-code-reviews.appspot.com/1109801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
