Revision: 9240
Author: unn...@google.com
Date: Tue Nov 16 10:13:16 2010
Log: Close the readers
Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9240
Modified:
/trunk/user/src/com/google/gwt/junit/server/JUnitHostImpl.java
/trunk/user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
=======================================
--- /trunk/user/src/com/google/gwt/junit/server/JUnitHostImpl.java Thu Sep
16 12:42:20 2010
+++ /trunk/user/src/com/google/gwt/junit/server/JUnitHostImpl.java Tue Nov
16 10:13:16 2010
@@ -218,13 +218,17 @@
BufferedReader bin = new BufferedReader(new InputStreamReader(in));
String line;
try {
- while ((line = bin.readLine()) != null) {
- if (line.charAt(0) == '#') {
- continue;
- }
- int idx = line.indexOf(',');
- toReturn.put(new SymbolName(line.substring(0, idx)),
- line.substring(idx + 1));
+ try {
+ while ((line = bin.readLine()) != null) {
+ if (line.charAt(0) == '#') {
+ continue;
+ }
+ int idx = line.indexOf(',');
+ toReturn.put(new SymbolName(line.substring(0, idx)),
+ line.substring(idx + 1));
+ }
+ } finally {
+ bin.close();
}
} catch (IOException e) {
toReturn = null;
=======================================
---
/trunk/user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
Thu Oct 21 12:57:55 2010
+++
/trunk/user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
Tue Nov 16 10:13:16 2010
@@ -123,15 +123,20 @@
toReturn = new SymbolMap();
String line;
String filename = symbolMapsDirectory + strongName + ".symbolMap";
+
try {
BufferedReader bin = new BufferedReader(new FileReader(filename));
- while ((line = bin.readLine()) != null) {
- if (line.charAt(0) == '#') {
- continue;
- }
- int idx = line.indexOf(',');
- toReturn.put(new String(line.substring(0, idx)),
- line.substring(idx + 1));
+ try {
+ while ((line = bin.readLine()) != null) {
+ if (line.charAt(0) == '#') {
+ continue;
+ }
+ int idx = line.indexOf(',');
+ toReturn.put(new String(line.substring(0, idx)),
+ line.substring(idx + 1));
+ }
+ } finally {
+ bin.close();
}
} catch (IOException e) {
toReturn = null;
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors