Thanks for the review, will submit with ValueProxy validation strategy previously discussed.
http://gwt-code-reviews.appspot.com/1108802/diff/1/20 File user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java (right): http://gwt-code-reviews.appspot.com/1108802/diff/1/20#newcode1239 user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java:1239: * Examine the arguments ond return value of a method and check any On 2010/11/17 22:23:02, rchandia wrote:
ond -> and
Done. http://gwt-code-reviews.appspot.com/1108802/diff/1/20#newcode1252 user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java:1252: // Check EntityProxy args ond return types against the domain On 2010/11/17 22:23:02, rchandia wrote:
ond -> and
Done. http://gwt-code-reviews.appspot.com/1108802/diff/1/22 File user/src/com/google/gwt/requestfactory/server/Resolver.java (right): http://gwt-code-reviews.appspot.com/1108802/diff/1/22#newcode91 user/src/com/google/gwt/requestfactory/server/Resolver.java:91: * Used to map the objecting being resolved and its API slice to the On 2010/11/17 22:23:02, rchandia wrote:
objecting -> object
Done. http://gwt-code-reviews.appspot.com/1108802/diff/1/22#newcode185 user/src/com/google/gwt/requestfactory/server/Resolver.java:185: * Given a method a domain object, return a value that can be encoded by the On 2010/11/17 22:23:02, rchandia wrote:
Fix javadoc
Done. http://gwt-code-reviews.appspot.com/1108802/diff/1/22#newcode203 user/src/com/google/gwt/requestfactory/server/Resolver.java:203: * @param the client object to resolve On 2010/11/17 22:23:02, rchandia wrote:
missing param name
Done. http://gwt-code-reviews.appspot.com/1108802/diff/1/27 File user/src/com/google/gwt/requestfactory/shared/RequestContext.java (left): http://gwt-code-reviews.appspot.com/1108802/diff/1/27#oldcode28 user/src/com/google/gwt/requestfactory/shared/RequestContext.java:28: * @return an {...@link EntityProxy} instance of type T On 2010/11/17 22:23:02, rchandia wrote:
No longer returns an EntityProxy
Done. http://gwt-code-reviews.appspot.com/1108802/diff/1/29 File user/src/com/google/gwt/requestfactory/shared/Violation.java (right): http://gwt-code-reviews.appspot.com/1108802/diff/1/29#newcode46 user/src/com/google/gwt/requestfactory/shared/Violation.java:46: * method will return a ValueProxy that contains the invalid values. Changed this API a little so that you can always retrieve the BaseProxy associated with the violation so it will work the same way for all proxy types. http://gwt-code-reviews.appspot.com/1108802/diff/1/30 File user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java (left): http://gwt-code-reviews.appspot.com/1108802/diff/1/30#oldcode385 user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java:385: * Resolves an IdMessage into an EntityProxyId. On 2010/11/17 22:23:02, rchandia wrote:
SimpleEntityProxyId
Done. http://gwt-code-reviews.appspot.com/1108802/diff/1/35 File user/src/com/google/gwt/requestfactory/shared/impl/EntityProxyCategory.java (right): http://gwt-code-reviews.appspot.com/1108802/diff/1/35#newcode31 user/src/com/google/gwt/requestfactory/shared/impl/EntityProxyCategory.java:31: * ValueProxies are equal if they are from the same RequestContext and their This was a bad copy-and-paste of the javadoc. http://gwt-code-reviews.appspot.com/1108802/diff/1/41 File user/src/com/google/gwt/requestfactory/shared/impl/SimpleProxyId.java (right): http://gwt-code-reviews.appspot.com/1108802/diff/1/41#newcode22 user/src/com/google/gwt/requestfactory/shared/impl/SimpleProxyId.java:22: * The base implementation of id objects in the RequestFactory system. This On 2010/11/17 22:23:02, rchandia wrote:
This...
Done. http://gwt-code-reviews.appspot.com/1108802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
