Reviewers: rchandia,
Description:
Add a test for issue 5134 to ensure that RequestFactory interfaces can
be extended.
Patch by: bobv
Review by: rchandia
Reported by: pjulien
Please review this at http://gwt-code-reviews.appspot.com/1138801/show
Affected files:
A user/test/com/google/gwt/requestfactory/shared/BasicRequestFactory.java
M user/test/com/google/gwt/requestfactory/shared/SimpleRequestFactory.java
Index:
user/test/com/google/gwt/requestfactory/shared/BasicRequestFactory.java
===================================================================
--- user/test/com/google/gwt/requestfactory/shared/BasicRequestFactory.java
(revision 0)
+++ user/test/com/google/gwt/requestfactory/shared/BasicRequestFactory.java
(revision 0)
@@ -0,0 +1,27 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.requestfactory.shared;
+
+/**
+ * A base type for {...@link SimpleRequestFactory} to ensure that extending
+ * RequestFactory interfaces works correctly.
+ */
+public interface BasicRequestFactory extends RequestFactory {
+
+ LoggingRequest loggingRequest();
+
+ UserInformationRequest userInformationRequest();
+}
Index:
user/test/com/google/gwt/requestfactory/shared/SimpleRequestFactory.java
===================================================================
---
user/test/com/google/gwt/requestfactory/shared/SimpleRequestFactory.java
(revision 9266)
+++
user/test/com/google/gwt/requestfactory/shared/SimpleRequestFactory.java
(working copy)
@@ -19,13 +19,9 @@
* Simple RequesetFactory interface with two domain objects, and our
standard
* UserInformation and Logging services.
*/
-public interface SimpleRequestFactory extends RequestFactory {
-
- LoggingRequest loggingRequest();
+public interface SimpleRequestFactory extends BasicRequestFactory {
SimpleBarRequest simpleBarRequest();
-
+
SimpleFooRequest simpleFooRequest();
-
- UserInformationRequest userInformationRequest();
}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
