LGTM

Tested and everything works well.


http://gwt-code-reviews.appspot.com/1126801/diff/2002/6002
File
samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellTable.java
(right):

http://gwt-code-reviews.appspot.com/1126801/diff/2002/6002#newcode178
samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwCellTable.java:178:
cellTable.addColumn(checkColumn,
SafeHtmlUtils.fromSafeConstant("<br>"));
This wasn't added in this patch, but should this be "<br/>" to be valid
xhtml?

http://gwt-code-reviews.appspot.com/1126801/diff/2002/6003
File user/src/com/google/gwt/cell/client/CheckboxCell.java (right):

http://gwt-code-reviews.appspot.com/1126801/diff/2002/6003#newcode67
user/src/com/google/gwt/cell/client/CheckboxCell.java:67: * @param
handlesSelection true if the cell modifies the selection satte
typo: satte -> state

http://gwt-code-reviews.appspot.com/1126801/diff/2002/6004
File user/src/com/google/gwt/user/cellview/client/AbstractHasData.java
(right):

http://gwt-code-reviews.appspot.com/1126801/diff/2002/6004#newcode395
user/src/com/google/gwt/user/cellview/client/AbstractHasData.java:395:
public T getVisibleItem(int indexOnPage) {
Javadoc

http://gwt-code-reviews.appspot.com/1126801/diff/2002/6016
File user/test/com/google/gwt/cell/client/CheckboxCellTest.java (right):

http://gwt-code-reviews.appspot.com/1126801/diff/2002/6016#newcode49
user/test/com/google/gwt/cell/client/CheckboxCellTest.java:49: }
Why are these wrapped in their own blocks?

http://gwt-code-reviews.appspot.com/1126801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to