http://gwt-code-reviews.appspot.com/1148801/diff/1/3
File user/src/com/google/gwt/autobean/shared/AutoBeanUtils.java (right):

http://gwt-code-reviews.appspot.com/1148801/diff/1/3#newcode290
user/src/com/google/gwt/autobean/shared/AutoBeanUtils.java:290: return
true;
Move these two statements into the previous == null case to make the
logic easier to follow

http://gwt-code-reviews.appspot.com/1148801/diff/1/3#newcode328
user/src/com/google/gwt/autobean/shared/AutoBeanUtils.java:328: &&
sameOrEquals(map.values(), otherMap.values(), pending);
How does this work if sameOrEquals(Collection, Collection) relies on
element iteration order?

http://gwt-code-reviews.appspot.com/1148801/diff/1/4
File
user/src/com/google/gwt/requestfactory/shared/DefaultProxyStore.java
(right):

http://gwt-code-reviews.appspot.com/1148801/diff/1/4#newcode35
user/src/com/google/gwt/requestfactory/shared/DefaultProxyStore.java:35:
* MyFooProxy someProxy = ...;
Describe (or hint) how entity sparseness relates to what gets
serialized.

http://gwt-code-reviews.appspot.com/1148801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to