Konstantin, we have a separate release branch for 2.1.1 that is forked from
trunk.  Your change has not been integrated into that branch, so when I
picked up a piece of your code in UiBinderWriter it broke testing in the
release branch. This change was only applied to the release branch, not to
trunk, so your code should be intact.  Please let me know if you're seeing
any issues with trunk.

Thanks,
Stephanie

On Thu, Nov 25, 2010 at 3:22 PM, Konstantin.Scheglov <
konstantin.scheg...@gmail.com> wrote:

>
>
> > Then other pieces of the change were not integrated, as this was
> preventing
> > the 2.1 branch from building.
>
>   I see method getProvidedField() in DesignTimeUtils in SVN trunk, so
> I'm not sure what could be missed.
>  I also regularly build GWT from project in SVN without build
> problems.
>
>
> > On Nov 25, 2010 8:12 AM, "Konstantin.Scheglov" <
> >
> >
> >
> >
> >
> >
> >
> > konstantin.scheg...@gmail.com> wrote:
> >
> > > No!
> > > This change breaks @UiField(provided=true) support in GWT Designer,
> > > important feature which we want to support for GWT 2.1.1.
> >
> > > On 24 ноя, 19:55, codesite-nore...@google.com wrote:
> > >> Revision: 9277
> > >> Author: gwt.mirror...@gmail.com
> > >> Date: Wed Nov 24 08:54:59 2010
> > >> Log: Removing reference to designTime.getProvidedField()
> >
> > >>http://code.google.com/p/google-web-toolkit/source/detail?r=9277
> >
> > >> Modified:
> >
> > /releases/2.1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > >> =======================================
> > >> ---
> > >>
> /releases/2.1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
> > >> Fri Nov 19 05:49:25 2010
> > >> +++
> > >>
> /releases/2.1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
> > >> Wed Nov 24 08:54:59 2010
> > >> @@ -1093,15 +1093,8 @@
> >
> > >>           // TODO why can this be null?
> > >>           if (fieldWriter != null) {
> > >> -          String initializer;
> > >> -          if (designTime.isDesignTime()) {
> > >> -            String typeName =
> > >> ownerField.getType().getRawType().getQualifiedSourceName();
> > >> -            initializer = designTime.getProvidedField(typeName,
> > >> -                ownerField.getName());
> > >> -          } else {
> > >> -            initializer = formatCode("owner.%1$s", fieldName);
> > >> -          }
> > >> -          fieldManager.lookup(fieldName).setInitializer(initializer);
> > >> +          fieldManager.lookup(fieldName).setInitializer(
> > >> +              formatCode("owner.%1$s", fieldName));
> > >>           }
> > >>         }
> > >>       }
> > >> @@ -1215,4 +1208,3 @@
> > >>       designTime.addDeclarations(w);
> > >>     }
> > >>   }
> > >> -
> >
> > > --
> > >http://groups.google.com/group/Google-Web-Toolkit-Contributors
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to