http://gwt-code-reviews.appspot.com/1129801/diff/4001/5024 File user/src/com/google/gwt/cell/client/Cell.java (right):
http://gwt-code-reviews.appspot.com/1129801/diff/4001/5024#newcode65 user/src/com/google/gwt/cell/client/Cell.java:65: context.key = key; On 2010/11/29 23:24:01, jlabanca wrote:
It seems sort of arbitrary to exclude the value from the Context, and
I don't
see what value it adds. Also, the key is paired to the value, so that
would have
to be a separate arg as well.
The Cell is a flyweight, so it shouldn't maintain any state unless
absolutely
necessary. IMHO, for a flyweight like Cell, the value is tightly bound
to the
Context where the value is being rendered.
Should the Context contain the state that is shared between Cells, or all the state of a Cell? If it's the former, the value is the one part of the state that isn't shared. http://gwt-code-reviews.appspot.com/1129801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
