On Thu, Dec 2, 2010 at 1:35 PM, Luis Solano <luissolan...@gmail.com> wrote:
> I have checked out the trunk and configured my eclipse as said here: > > http://code.google.com/p/google-web-toolkit/source/browse/trunk/eclipse/README.txt > . > I have set the checkstyle and the error/warning configuration and then > imported the gwt-user and gwt-dev projects. The problem is that I get > 33 checkstyle problems and 3314 Java Problems (all warnings and the > first 100 are raw type warnings) in revision 9344. is this ok? if yes, > should this warnings be solved? And just in case, it's ok to send > patches with warnings? (I guess the answer is NO) It's sort of a known-issue broken-window. Some of them stem from third-party code that has come into GWT, such as Rhino or ASM. Removing warnings in original GWT code is generally a Good Thing. > The other question is about the workspace encoding. I'm on a mac. > Should I leave the MacRoman encoding for my workspace or should I > change it to another like utf-8? > All GWT java source is UTF-8, so definitely use that. Scott -- http://groups.google.com/group/Google-Web-Toolkit-Contributors