LGTM except for checkstyle errors.

http://gwt-code-reviews.appspot.com/1206801/diff/1/2
File
samples/validation/src/com/google/gwt/sample/validation/shared/Person.java
(right):

http://gwt-code-reviews.appspot.com/1206801/diff/1/2#newcode38
samples/validation/src/com/google/gwt/sample/validation/shared/Person.java:38:

Checkstyle

http://gwt-code-reviews.appspot.com/1206801/diff/1/2#newcode50
samples/validation/src/com/google/gwt/sample/validation/shared/Person.java:50:
protected long getSsn() {
Checkstyle error

http://gwt-code-reviews.appspot.com/1206801/diff/1/4
File samples/validationtck/style/text/junit-noframes.xsl (right):

http://gwt-code-reviews.appspot.com/1206801/diff/1/4#newcode45
samples/validationtck/style/text/junit-noframes.xsl:45: <xsl:value-of
select="$passedCount" /> <xsl:text> Pass </xsl:text>
Is it possible to add some punctuation to make parsing the message
easier on the eyes?

http://gwt-code-reviews.appspot.com/1206801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to