LGTM. With JavaDoc nits.

http://gwt-code-reviews.appspot.com/1208801/diff/3001/4002
File
samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java
(right):

http://gwt-code-reviews.appspot.com/1208801/diff/3001/4002#newcode34
samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java:34:
* Validator marker for the Valiation Sample project. Only the classes
listed
Validation

http://gwt-code-reviews.appspot.com/1208801/diff/3001/4005
File
samples/validationtck/src/org/hibernate/jsr303/tck/super/org/hibernate/jsr303/tck/common/TCKValidationProvider.java
(right):

http://gwt-code-reviews.appspot.com/1208801/diff/3001/4005#newcode35
samples/validationtck/src/org/hibernate/jsr303/tck/super/org/hibernate/jsr303/tck/common/TCKValidationProvider.java:35:
* <li>Meved cast call.</li>
Moved

http://gwt-code-reviews.appspot.com/1208801/diff/3001/4019
File
user/src/com/google/gwt/validation/client/GwtValidationProviderResolver.java
(right):

http://gwt-code-reviews.appspot.com/1208801/diff/3001/4019#newcode34
user/src/com/google/gwt/validation/client/GwtValidationProviderResolver.java:34:
private final List<ValidationProvider<?>> defaultList;
Would it be better to make this static?

http://gwt-code-reviews.appspot.com/1208801/diff/3001/4022
File user/src/com/google/gwt/validation/client/Validation.java (right):

http://gwt-code-reviews.appspot.com/1208801/diff/3001/4022#newcode197
user/src/com/google/gwt/validation/client/Validation.java:197: *
defined, use the default ValidationProviderResolver
Is the Javadoc in this class still accurate?

http://gwt-code-reviews.appspot.com/1208801/diff/3001/4022#newcode212
user/src/com/google/gwt/validation/client/Validation.java:212: * default
Bean Validation provider and following the XML configuration.
GWT does not use XML config, right?

http://gwt-code-reviews.appspot.com/1208801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to