I looked through the other two patches and didn't see any unit tests.
Since there are 5 different ways to cache or not cache generator
results, and none of them are being exercised yet it would be nice to
have a unit test.


http://gwt-code-reviews.appspot.com/1232801/diff/1/4
File dev/core/src/com/google/gwt/dev/DevModeBase.java (right):

http://gwt-code-reviews.appspot.com/1232801/diff/1/4#newcode251
dev/core/src/com/google/gwt/dev/DevModeBase.java:251:
a few lines here w/ added whitespace.

http://gwt-code-reviews.appspot.com/1232801/diff/1/16
File dev/core/src/com/google/gwt/dev/javac/rebind/RebindStatus.java
(right):

http://gwt-code-reviews.appspot.com/1232801/diff/1/16#newcode27
dev/core/src/com/google/gwt/dev/javac/rebind/RebindStatus.java:27: /*
if you change these to /** javadoc style comments, the text will land in
the javadoc documentation.

http://gwt-code-reviews.appspot.com/1232801/diff/1/20
File dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java
(right):

http://gwt-code-reviews.appspot.com/1232801/diff/1/20#newcode107
dev/core/src/com/google/gwt/dev/shell/StandardRebindOracle.java:107:
more stray whitespace

http://gwt-code-reviews.appspot.com/1232801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to