http://gwt-code-reviews.appspot.com/1230801/diff/1/3 File samples/validation/ValidationMesssges-i18n (right):
http://gwt-code-reviews.appspot.com/1230801/diff/1/3#newcode1 samples/validation/ValidationMesssges-i18n:1: #!/bin/sh On 2010/12/20 19:10:53, rchandia wrote:
I think this file does not need to be committed.
Done. http://gwt-code-reviews.appspot.com/1230801/diff/1/4 File samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml (right): http://gwt-code-reviews.appspot.com/1230801/diff/1/4#newcode27 samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml:27: <!-- Specify the Validator for the Validaiton bootstrap to use. --> On 2010/12/20 19:10:53, rchandia wrote:
Validaiton -> Validation
Done. http://gwt-code-reviews.appspot.com/1230801/diff/1/4#newcode33 samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml:33: <!-- TODO(nchalko) figure out how to make this a attribute of the GwtValidtion On 2010/12/20 19:10:53, rchandia wrote:
GwtValidtion -> GwtValidation
Done. http://gwt-code-reviews.appspot.com/1230801/diff/1/4#newcode35 samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml:35: <!-- specify the ValidaitonMessageResolver to use for your custom validation messages --> On 2010/12/20 19:10:53, rchandia wrote:
ValidaitonMessageResolver -> ValidationMessageResolver
Done. http://gwt-code-reviews.appspot.com/1230801/diff/1/14 File samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/TckTest.gwt.xml (right): http://gwt-code-reviews.appspot.com/1230801/diff/1/14#newcode23 samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/TckTest.gwt.xml:23: <exclude name="*GwtSuite.java" /> On 2010/12/20 19:10:53, rchandia wrote:
The approach commonly used in trunk/user has been to move Suites up a
folder and
thus to completely move them out of the GWT module.
I have a larger test re-factoring coming, I will move the suites then. http://gwt-code-reviews.appspot.com/1230801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
