http://gwt-code-reviews.appspot.com/1224801/diff/1/2
File user/src/com/google/gwt/junit/client/GWTTestCase.java (right):

http://gwt-code-reviews.appspot.com/1224801/diff/1/2#newcode445
user/src/com/google/gwt/junit/client/GWTTestCase.java:445: // Check to
see if gwt.devjar is null. If so, notify the
On 2010/12/16 19:43:39, rdayal wrote:
Is this system property required?

This is a tough one, because I don't think it's strictly required, but
the devjar has things such as the GWT devmode bridge and the GWT
compiler. Can you think of a case where it wouldn't be set though? Let
me ask some non-GPE and non-Eclipse users to add this change and confirm
nothing breaks before asking for the LGTM.

http://gwt-code-reviews.appspot.com/1224801/diff/1/2#newcode448
user/src/com/google/gwt/junit/client/GWTTestCase.java:448:
testResult.addError(this, new Throwable("No GWT devjar property found.
Did you mean to run as a GWT JUnit Test instead of a JUnit Test?"));
On 2010/12/16 19:43:39, rdayal wrote:
Suggestion:

"No GWT devjar property found. Did you mean to run as a GWT JUnit Test
instead
of a JUnit Test?" -->

"The gwt.devjar property has not been set. If you are using the Google
Plugin
for Eclipse, you should be running this test as a 'GWT JUnit Test',
not a plain
'JUnit Test'."

Done.

http://gwt-code-reviews.appspot.com/1224801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to