(<grumble>The reply function doesn't publish comments</grumble>)
http://gwt-code-reviews.appspot.com/1236801/diff/1/3 File user/src/com/google/gwt/resources/ext/ResourceContext.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/1/3#newcode147 user/src/com/google/gwt/resources/ext/ResourceContext.java:147: * a given method. This data will be populated and available prior to any method, based on the presence of an {...@link Source} annotation or the method or the {...@link DefaultExtensions} annotation of the ResourceGenerator. The whole populated and available statement seems kind of a weird thing to guarantee here. Is there any time where it's invalid to call this method? http://gwt-code-reviews.appspot.com/1236801/diff/1/3#newcode170 user/src/com/google/gwt/resources/ext/ResourceContext.java:170: Whitespace. http://gwt-code-reviews.appspot.com/1236801/diff/1/6 File user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/1/6#newcode231 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:231: Whitespace, here and elsewhere. http://gwt-code-reviews.appspot.com/1236801/diff/1/6#newcode362 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:362: return new RebindResult(RebindStatus.USE_ALL_NEW, createdClassName, cpi); Where do the previously-emitted resource files live (e.g. *.cache.png)? Are they deleted between refreshes so that staleness will become glaring obvious? http://gwt-code-reviews.appspot.com/1236801/diff/1/6#newcode438 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:438: long lastModified = generatorContext.getSourceLastModifiedTime(sourceType); How does this handle the case where a CssResource subtype is not necessarily defined in the same compilation unit as the ClientBundle subtype? http://gwt-code-reviews.appspot.com/1236801/diff/1/6#newcode655 user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java:655: cacheable = false; Why not just return false immediately? http://gwt-code-reviews.appspot.com/1236801/diff/1/7 File user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/1/7#newcode142 user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java:142: Whitespace, here and elsewhere. http://gwt-code-reviews.appspot.com/1236801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
