LGTM with nits/suggestions
http://gwt-code-reviews.appspot.com/1240801/diff/1/3 File user/src/com/google/gwt/autobean/rebind/model/AutoBeanMethod.java (right): http://gwt-code-reviews.appspot.com/1240801/diff/1/3#newcode201 user/src/com/google/gwt/autobean/rebind/model/AutoBeanMethod.java:201: assert type != null : "type"; maybe change the assert return string to something more descriptive, like: "type cannot be null" http://gwt-code-reviews.appspot.com/1240801/diff/1/4 File user/test/com/google/gwt/autobean/shared/AutoBeanCodexTest.java (right): http://gwt-code-reviews.appspot.com/1240801/diff/1/4#newcode66 user/test/com/google/gwt/autobean/shared/AutoBeanCodexTest.java:66: } Seems it would be slightly more of a test if these constant names were different (e.g. FOO1, FOO2, FOO3).... http://gwt-code-reviews.appspot.com/1240801/diff/1/4#newcode100 user/test/com/google/gwt/autobean/shared/AutoBeanCodexTest.java:100: Map<EnumThroughMapKey, EnumThroughMapValue> getParameterizedMap(); Are these new methods used anywhere? http://gwt-code-reviews.appspot.com/1240801/diff/1/4#newcode127 user/test/com/google/gwt/autobean/shared/AutoBeanCodexTest.java:127: } white space: blank lines deleted http://gwt-code-reviews.appspot.com/1240801/diff/1/4#newcode206 user/test/com/google/gwt/autobean/shared/AutoBeanCodexTest.java:206: public void testEnumThroughParameterization() { It's not clear how this is testing parameterization? I see now it happens in the generator for Factory, but it might help clarify to explain that here (and elsewhere in these tests?). I had to actually run the test, with the -gen flag, in order to understand how all this is working :) http://gwt-code-reviews.appspot.com/1240801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
