http://gwt-code-reviews.appspot.com/1245801/diff/1/2
File samples/validationtck/build.xml (right):

http://gwt-code-reviews.appspot.com/1245801/diff/1/2#newcode140
samples/validationtck/build.xml:140:
executable="${basedir}/countMarkedTests.sh"
I think this breaks support for non-unix users.

http://gwt-code-reviews.appspot.com/1245801/diff/1/3
File samples/validationtck/countMarkedTests.sh (right):

http://gwt-code-reviews.appspot.com/1245801/diff/1/3#newcode1
samples/validationtck/countMarkedTests.sh:1: #!/bin/bash
Use /bin/sh

http://gwt-code-reviews.appspot.com/1245801/diff/1/20
File
samples/validationtck/test/com/google/gwt/sample/validationtck/util/Failing.java
(right):

http://gwt-code-reviews.appspot.com/1245801/diff/1/20#newcode35
samples/validationtck/test/com/google/gwt/sample/validationtck/util/Failing.java:35:
* .
Hard to understand. Trailing dot.

http://gwt-code-reviews.appspot.com/1245801/diff/1/21
File
samples/validationtck/test/com/google/gwt/sample/validationtck/util/NonTckTest.java
(right):

http://gwt-code-reviews.appspot.com/1245801/diff/1/21#newcode35
samples/validationtck/test/com/google/gwt/sample/validationtck/util/NonTckTest.java:35:
* {...@link NonTckTest}.
Rephrase

http://gwt-code-reviews.appspot.com/1245801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to