On Wed, Jan 5, 2011 at 2:13 PM, <zun...@google.com> wrote: > On 2011/01/05 18:59:02, scottb wrote: > >> LGTM, I think. >> > > What is that supposed to mean?!? >
Sorry, it means I didn't scrutinize this to the Nth degree, just looked over it at a high level. > I assume all the new units are being moved from code snippets embedded >> in exist test code? >> > > More or less. The only difference I remember are the names, and that > there are some types that were embedded in the same compilation unit > that I moved to be separate types in order to make the > CheckedJavaResource to bytecode mapping work without many changes. > > The snippets are actually copied - the compiler gets run on the .java > files to make byte code. The constant strings in the > TypeOracleMediatorTestBase.java still get used when the > TypeOracleMediatorFromSourceTest gets run. I wasn't sure how to get > both byte code and the body of the .java file at run time. Ahh... that's what I was concerned about. Having two versions of the source seems bad. Do you plan to remove the TypeOracleMediatorFromSourceTest in the near future, or will they exist side by side indefinitely? If it's the latter, it's worth mentioning that some of our tests do require test source code to be on the classpath to run, so we could make the Java files canonical. > I did work hard to land this in multiple patches. I changed the names of > some of the identifiers because I just couldn't keep track of names like > "Class1", "Class2", ... which got mapped onto different > CheckedJavaResource identifiers. Do you want me to un-sort the file? No no, I was just explaining why I was being less thorough. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
