http://gwt-code-reviews.appspot.com/1260801/diff/1/3 File user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java (right):
http://gwt-code-reviews.appspot.com/1260801/diff/1/3#newcode25 user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java:25: * {...@link EditorDelegate#subscribe()}. Add a note that this interface is implemented by generated code, and that incompatible changes may be made from time to time? I should do the same to UiBinder http://gwt-code-reviews.appspot.com/1260801/diff/1/3#newcode85 user/src/com/google/gwt/editor/client/SimpleBeanEditorDriver.java:85: * JSR 303 Validator. The violations will be converted into Let's try to get away from the JSR verbiage. Just "probably generated by a {...@link javax.validation.Validator}." http://gwt-code-reviews.appspot.com/1260801/diff/1/5 File user/src/com/google/gwt/editor/client/impl/EditorDriverUtils.java (right): http://gwt-code-reviews.appspot.com/1260801/diff/1/5#newcode26 user/src/com/google/gwt/editor/client/impl/EditorDriverUtils.java:26: public class EditorDriverUtils { How about changing this to abstract class SimpleViolation, rather than using the nested interface? Util classes always give me a misc-rash. http://gwt-code-reviews.appspot.com/1260801/diff/1/5#newcode32 user/src/com/google/gwt/editor/client/impl/EditorDriverUtils.java:32: public static class ConstraintViolationIterable implements And this doesn't need to be a public type. Could have a static method SimpleViolation#iterableFromConstraintViolations(Iterable<ConstraintViolation<?>>) http://gwt-code-reviews.appspot.com/1260801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
