LGTM

http://gwt-code-reviews.appspot.com/1268801/diff/1/2
File dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java (right):

http://gwt-code-reviews.appspot.com/1268801/diff/1/2#newcode29
dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:29: * Returns
the equivalent of {...@link Class#getName()} if the type were loaded.
This isn't true as far as I know. I believe this always returns the
"field descriptor" for a type. See JVMS 4.3. I think we should javadoc
it as such. Adding a couple of examples may not hurt: String.class =>
"Ljava/lang/String;". boolean.class => "Z"

http://gwt-code-reviews.appspot.com/1268801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to