http://gwt-code-reviews.appspot.com/1273801/diff/1/2 File user/src/com/google/gwt/user/client/rpc/CustomFieldSerializer.java (right):
http://gwt-code-reviews.appspot.com/1273801/diff/1/2#newcode19 user/src/com/google/gwt/user/client/rpc/CustomFieldSerializer.java:19: * An interface that may be implemented by class-based custom field serializers which will reduce
80 chars, throughout the change
http://gwt-code-reviews.appspot.com/1273801/diff/1/2#newcode37 user/src/com/google/gwt/user/client/rpc/CustomFieldSerializer.java:37: } Why only serialize? Shouldn't there be instantiateInstance and deserializeInstance methods as well? http://gwt-code-reviews.appspot.com/1273801/diff/1/3 File user/src/com/google/gwt/user/client/rpc/core/java/lang/Boolean_CustomFieldSerializer.java (right): http://gwt-code-reviews.appspot.com/1273801/diff/1/3#newcode44 user/src/com/google/gwt/user/client/rpc/core/java/lang/Boolean_CustomFieldSerializer.java:44: public void serializeInstance(final SerializationStreamWriter streamWriter, GWT style is to only use final on locals/parameters when it is required, such as for reference in an anonymous inner class. http://gwt-code-reviews.appspot.com/1273801/diff/1/6 File user/src/com/google/gwt/user/client/rpc/core/java/lang/Double_CustomFieldSerializer.java (right): http://gwt-code-reviews.appspot.com/1273801/diff/1/6#newcode45 user/src/com/google/gwt/user/client/rpc/core/java/lang/Double_CustomFieldSerializer.java:45: throws SerializationException { Continuation lines should be indented +4 columns. You might want to look in eclipse/README.txt to setup eclipse so formatting/etc matches our style guide. http://gwt-code-reviews.appspot.com/1273801/diff/1/33 File user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java (right): http://gwt-code-reviews.appspot.com/1273801/diff/1/33#newcode288 user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java:288: private static class CustomFieldSerializerHandle { What is the benefit of having this class over just storing a CustomFieldSerializer<?>, since it only holds a CFS instance and it must be initialized at creation? http://gwt-code-reviews.appspot.com/1273801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
