http://gwt-code-reviews.appspot.com/1294801/diff/3001/4002 File user/test/com/google/gwt/dom/client/FrameTests.java (right):
http://gwt-code-reviews.appspot.com/1294801/diff/3001/4002#newcode49 user/test/com/google/gwt/dom/client/FrameTests.java:49: final Timer timer = new Timer() { On 2011/01/14 19:14:48, jlabanca wrote:
Do you need this timer? The test will time out if onload is never
triggered. Done. http://gwt-code-reviews.appspot.com/1294801/diff/3001/4002#newcode75 user/test/com/google/gwt/dom/client/FrameTests.java:75: delayTestFinish(2 * delayMillis); On 2011/01/14 19:14:48, jlabanca wrote:
Move this above the line where you create the iframe to avoid timing
issues,
especially in HtmlUnit. If the iframe happens to load synchronously
or very
quickly, the onload event might fire before delayTestFinish. In
general, always
call delayTestFinish() before calling the thing that will trigger an asynchronous event.
Done. http://gwt-code-reviews.appspot.com/1294801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
