I know this isn't 100% perfect, but this was my first time looking at
the ui:binder code. See comments below on some areas that I know need
improvement.


http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002
File
user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java
(left):

http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002#oldcode72
user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java:72:
DialogBox.class.getCanonicalName()));
I made this a method because I'm working on ResizeDialogBox and with
this as a protected method, I'll be able to reuse the
handleConstructorArgs.

http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002
File
user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java
(right):

http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002#newcode80
user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java:80:
protected String getPackage(XMLElement element) {
There has to be a cleaner way of doing this... I just couldn't find the
right method call.

http://gwt-code-reviews.appspot.com/1149803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to