http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002
File
user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java
(right):
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002#newcode47
user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java:47:
} else if ("captionWidget".equals(child.getLocalName())) {
On 2011/01/20 20:33:11, rjrjr wrote:
Should be "customCaption"
Done.
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002#newcode52
user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java:52:
captionWidget = child.consumeSingleChildElement();
On 2011/01/20 20:33:11, rjrjr wrote:
Need to be stricter. Shouldn't allow both caption and customCaption.
See
TabLayoutPanelParser for example.
Done.
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002#newcode80
user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java:80:
protected String getPackage(XMLElement element) {
On 2011/01/20 20:33:11, rjrjr wrote:
UiBinderWriter.findFieldType(XMLElement)
On 2011/01/19 19:49:38, Jeff Larsen wrote:
> There has to be a cleaner way of doing this... I just couldn't find
the right
> method call.
Done.
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41001
File user/src/com/google/gwt/user/client/ui/DialogBox.java (right):
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41001#newcode95
user/src/com/google/gwt/user/client/ui/DialogBox.java:95: * You may also
create your own header caption. The caption must extend {@Link
On 2011/01/20 20:33:11, rjrjr wrote:
s/extend/implement/, and it's {@link Caption}
Done.
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41001#newcode96
user/src/com/google/gwt/user/client/ui/DialogBox.java:96: *
DialogBox.Caption}. This will provides you with the ability to add
On 2011/01/20 20:33:11, rjrjr wrote:
The last sentence isn't really needed.
Done.
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41001#newcode106
user/src/com/google/gwt/user/client/ui/DialogBox.java:106: *
<g:captionWidget><foo:Bar/></g:captionWidget>
On 2011/01/20 20:33:11, rjrjr wrote:
I think we typically call elements like this g:customCaption
Also, wouldn't it be an error to provide both g:caption and
g:customCaption?
It worked before, but now it won't. Done.
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41001#newcode115
user/src/com/google/gwt/user/client/ui/DialogBox.java:115: * You may
also create your own header caption. The caption must extend {@Link
On 2011/01/20 20:33:11, rjrjr wrote:
Redundant, though it's better here
Done.
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41001#newcode117
user/src/com/google/gwt/user/client/ui/DialogBox.java:117: * follows:
On 2011/01/20 20:33:11, rjrjr wrote:
ahem
copy/paste booboo.
Fixed with more explicit text to reflect the fact you can't have both
caption and customCaption.
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41001#newcode203
user/src/com/google/gwt/user/client/ui/DialogBox.java:203: * Creates an
empty dialog box specifying its {@link Caption}. auto-hide is
On 2011/01/20 20:33:11, rjrjr wrote:
Creates an empty dialog box with a custom {@link Caption}.
No need for the "auto-hide is set to false and" phrase, should be
consistent
with the verbiage on the default constructor
Done.
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41001#newcode230
user/src/com/google/gwt/user/client/ui/DialogBox.java:230: *
implementation of the {@link Caption}. It should not be shown until its
On 2011/01/20 20:33:11, rjrjr wrote:
"and a custom {@link Caption}."
Done.
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41003
File user/test/com/google/gwt/user/client/ui/DialogBoxTest.java (right):
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41003#newcode141
user/test/com/google/gwt/user/client/ui/DialogBoxTest.java:141:
assertEquals("text", dialogBox.getHTML().toLowerCase());
On 2011/01/20 20:33:11, rjrjr wrote:
Why was this change needed?
It isn't... I'm not sure why I did that.
reverted.
http://gwt-code-reviews.appspot.com/1149803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
