http://gwt-code-reviews.appspot.com/1293801/diff/1/2 File user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java (right):
http://gwt-code-reviews.appspot.com/1293801/diff/1/2#newcode41 user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java:41: static PlaceHistoryGeneratorContext create(TreeLogger logger, javadoc to warn of the null return http://gwt-code-reviews.appspot.com/1293801/diff/1/3 File user/src/com/google/gwt/place/rebind/PlaceHistoryMapperGenerator.java (right): http://gwt-code-reviews.appspot.com/1293801/diff/1/3#newcode54 user/src/com/google/gwt/place/rebind/PlaceHistoryMapperGenerator.java:54: return null; Wait, what? What happens when a code generator returns null? http://gwt-code-reviews.appspot.com/1293801/diff/1/4 File user/test/com/google/gwt/place/impl/PlaceHistoryMapperGeneratorTest.java (right): http://gwt-code-reviews.appspot.com/1293801/diff/1/4#newcode52 user/test/com/google/gwt/place/impl/PlaceHistoryMapperGeneratorTest.java:52: * The goal is only to test that the generator doesn't fail (but doesn't generate anything either). line too long http://gwt-code-reviews.appspot.com/1293801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors