LGTM. With nits.

http://gwt-code-reviews.appspot.com/1287802/diff/1/2
File
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
(right):

http://gwt-code-reviews.appspot.com/1287802/diff/1/2#newcode91
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java:91:
private static Function<java.beans.PropertyDescriptor, String>
PROPERTY_DESCRIPTOR_TO_NAME = new
Function<java.beans.PropertyDescriptor, String>() {
Line length

http://gwt-code-reviews.appspot.com/1287802/diff/1/2#newcode94
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java:94:
return pd.getName();
Indentation

http://gwt-code-reviews.appspot.com/1287802/diff/1/2#newcode108
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java:108:
*
Indentation got messed up.

http://gwt-code-reviews.appspot.com/1287802/diff/1/2#newcode256
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java:256:
// Write the wrappers after we know which is needed
is -> are

http://gwt-code-reviews.appspot.com/1287802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to