LGTM + readme nits

http://gwt-code-reviews.appspot.com/1324801/diff/17001/18007
File dev/core/src/com/google/gwt/dev/shell/jetty/README-SSL.txt (right):

http://gwt-code-reviews.appspot.com/1324801/diff/17001/18007#newcode17
dev/core/src/com/google/gwt/dev/shell/jetty/README-SSL.txt:17: -server
:keystore=/path/to/keystore,password=password
insert an 'OR' here.

http://gwt-code-reviews.appspot.com/1324801/diff/17001/18007#newcode18
dev/core/src/com/google/gwt/dev/shell/jetty/README-SSL.txt:18: -server
:keystore=/path/to/keystore,pwfile=/path/to/password/file
thanks for adding the pwfile option!

I would suggest adding something along the lines of:
"You can specify the password directly on the command line using the
'password=' option or you may specify a file that contains the password
using the 'pwfile=' option. The former method is insecure and should not
be used if you care about keeping the password secret from other users
on your system.

http://gwt-code-reviews.appspot.com/1324801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to